RFR: 8306914: Implement JEP 458: Launch Multi-File Source-Code Programs [v7]

Christian Stein cstein at openjdk.org
Sat Dec 2 09:57:57 UTC 2023


On Fri, 1 Dec 2023 13:00:12 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test for implicit classes
>>   
>>   Preview notes normally emitted by `javac` are
>>   suppressed now, as they contain hints that
>>   does not apply to the source launcher and will
>>   lead to errors. For example: `-Xlint:preview`
>
> Just nits. Nice work.

@JimLaskey Thanks for the review - addressed all comments via https://github.com/openjdk/jdk/pull/13712/commits/70540efef8d1487ac3a2522e7299716ea3f46bc1

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13712#issuecomment-1837106820


More information about the compiler-dev mailing list