RFR: JDK-8321073: Defer policy of disabling annotation processing by default

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Dec 6 09:21:37 UTC 2023


On Wed, 6 Dec 2023 01:05:19 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> To allow more time for build tools to accommodate changes in javac's default annotation processing policy, disabling annotation processing by default will be deferred one release to JDK 23. 
> 
> This PR re-enables implicit annotation processing by default _for JDK 22_. It is an anti-delta of  JDK-8306819.
> 
> Please also review the CSR to restore the previous behavior for JDK 22:
> 
> https://bugs.openjdk.org/browse/JDK-8321321

Looks good

test/langtools/tools/javac/6341866/T6341866.java line 59:

> 57:         NONE(null),                     // don't use implicit compilation
> 58:         OPT_UNSET(null),                // implicit compilation, but no -implicit option
> 59:         OPT_NONE("-implicit:none"),     // implicit compilation wiith -implicit:none

Can we fix the typo?

test/langtools/tools/javac/6341866/T6341866.java line 60:

> 58:         OPT_UNSET(null),                // implicit compilation, but no -implicit option
> 59:         OPT_NONE("-implicit:none"),     // implicit compilation wiith -implicit:none
> 60:         OPT_CLASS("-implicit:class");   // implicit compilation wiith -implicit:class

Here too

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16988#pullrequestreview-1767064126
PR Review Comment: https://git.openjdk.org/jdk/pull/16988#discussion_r1416972088
PR Review Comment: https://git.openjdk.org/jdk/pull/16988#discussion_r1416972263


More information about the compiler-dev mailing list