RFR: 8321248: ClassFile API ClassModel::verify is inconsistent with the rest of the API [v2]

Adam Sotona asotona at openjdk.org
Wed Dec 6 10:40:51 UTC 2023

> ClassFile API `ClassModel::verify` accepts `ClassHierarchyResolver` as an optional argument and does not respect `ClassFile.ClassHierarchyResolverOption` of the actual context.
> Parsing, building and transforming take options from the actual `ClassFile` context and verification should follow the same API pattern.
> This patch removes `ClassModel::verify` methods and introduces new top level methods:
> List<VerifyError> ClassFile::verify(ClassModel model);
> List<VerifyError> ClassFile::verify(byte[] bytes);
> List<VerifyError> ClassFile::verify(Path path);
> Impact of the API change is minimal as the API has not been released yet.
> Please review.
> Thanks,
> Adam

Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

  reverted modified test


  - all: https://git.openjdk.org/jdk/pull/16947/files
  - new: https://git.openjdk.org/jdk/pull/16947/files/4485a369..bacdf481

 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16947&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16947&range=00-01

  Stats: 30 lines in 1 file changed: 30 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/16947.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16947/head:pull/16947

PR: https://git.openjdk.org/jdk/pull/16947

More information about the compiler-dev mailing list