RFR: 8321739: Source launcher fails with "Not a directory" error

Jan Lahoda jlahoda at openjdk.org
Tue Dec 12 15:24:32 UTC 2023


On Tue, 12 Dec 2023 08:56:58 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change to allow files sharing names with packages when using the Java source launcher.
> 
> The now used `!Files.exists()` returns a boolean value on Unix-based file systems instead of throwing an exception as `Files.notExists()` does when one or more elements of the tested path are files (and not directories), in addition of the the last element.
> 
> Tested: tier1

Looks good to me.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17076#pullrequestreview-1777765474


More information about the compiler-dev mailing list