RFR: JDK-8301201: Allow \n@ inside inline tags using inlineContent [v2]

Hannes Wallnöfer hannesw at openjdk.org
Wed Feb 1 16:43:51 UTC 2023


On Wed, 1 Feb 2023 00:01:17 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a simple change to allow the use of _newline_ _whitespace_ `@` inside inline tags that allow rich content (that is, those parsed with `inlineContent`) as compared to those that only allow plain text (that is, those parsed with `inlineText`).
>> 
>> The fix is to delete the code which recognizes `@` as the beginning of a block tag. Compare to the similar fix in [JDK-8241780](https://bugs.openjdk.org/browse/JDK-8241780)
>> 
>> The general `TagTest.java` is updated for the new feature.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix broken tests

Thanks for the extended comment for the `normalize` method. Looks good to me.

-------------

Marked as reviewed by hannesw (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12264


More information about the compiler-dev mailing list