RFR: JDK-8301636: Minor cleanup in CommentHelper and DocPretty

Jonathan Gibbons jjg at openjdk.org
Wed Feb 1 21:21:53 UTC 2023


On Wed, 1 Feb 2023 21:14:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some simple cleanup suggested by IntelliJ IDEA that would be too much of a distraction in an otherwise unrelated PR.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/CommentHelper.java line 159:

> 157:     }
> 158: 
> 159:     public TypeElement getReferencedClass(Element e) {

For what it's worth, I dislike the remaining `getReferenced`_Thing_ methods remaining in this class, since they are just null-safe wrappers around methods in `Utils` that are just wrappers for code in `java.lang.model`. But that's another more-manual cleanup for another day.

-------------

PR: https://git.openjdk.org/jdk/pull/12375


More information about the compiler-dev mailing list