RFR: JDK-8300914: Allow `@` as an escape in documentation comments [v2]
Jonathan Gibbons
jjg at openjdk.org
Thu Feb 2 19:55:28 UTC 2023
On Thu, 2 Feb 2023 18:05:18 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java line 231:
>>
>>> 229:
>>> 230: case '@':
>>> 231: if (newline) {
>>
>> Here and on L250: why do you set `newline` unconditionally immediately after reading a character?
>
> Oops, wrong "Here" line. Should be 238; so the two lines are 238 and 250.
`newline` is a flag with a name that is less than ideal. It indicates whether we are at the beginning of a line, part from whitespace. It is used to determine whether an `@` character should be treated as introducing a block tag. As soon as a non-white character is encountered, it is unconditionally set to `false`, and remains that way until the next newline is encountered.
-------------
PR: https://git.openjdk.org/jdk/pull/12372
More information about the compiler-dev
mailing list