Integrated: 7167356: (javac) investigate failing tests in JavacParserTest
Archie L. Cobbs
duke at openjdk.org
Mon Feb 6 20:31:01 UTC 2023
On Mon, 6 Feb 2023 15:35:29 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:
> This bug, created back in 2012, notes that three of the unit `@Test`s in `parser/JavacParserTest.java` are disabled because the functionality they verify was not yet implemented correctly at that time.
>
> That was a long time ago, and since then the functionality has been fixed and the tests are now working properly, so they can be enabled at long last.
>
> The third test also needs to be adjusted in order to succeed. It was (for some reason) expecting that an `enum` constant's source position would be reported as offset -1, instead of its actual source position (in this case, 23).
This pull request has now been integrated.
Changeset: 07fb4f9a
Author: Archie L. Cobbs <archie.cobbs at gmail.com>
Committer: Vicente Romero <vromero at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/07fb4f9a0bb4ed9d0f359b85fe0b0c38503ab9a5
Stats: 8 lines in 1 file changed: 2 ins; 4 del; 2 mod
7167356: (javac) investigate failing tests in JavacParserTest
Reviewed-by: vromero
-------------
PR: https://git.openjdk.org/jdk/pull/12444
More information about the compiler-dev
mailing list