RFR: JDK-8301810: Bug in doctree DocCommentTester.compress [v2]

Pavel Rappo prappo at openjdk.org
Tue Feb 7 15:47:15 UTC 2023

On Mon, 6 Feb 2023 19:00:02 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a minor but long-standing bug in the code to "compress" long strings in the `doctree` `DocCommentTester` class.
>> The primary change is in `DocCommentTester`, to fix the code, and make it somewhat more robust.  The change does break some golden output, in comments and files, so advantage is taken to increase the max size of compressed strings.
> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>  - Merge remote-tracking branch 'upstream/master' into 8301810.doctree-doccommenttester-compress
>  - JDK-8301810: Bug in doctree DocCommentTester.compress

Looks good.


Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12418

More information about the compiler-dev mailing list