RFR: JDK-8300914: Allow `@` as an escape in documentation comments [v5]

Pavel Rappo prappo at openjdk.org
Tue Feb 7 17:38:05 UTC 2023


On Mon, 6 Feb 2023 19:33:06 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a moderately simple update to permit the use of `@` as the escape character in a limited set of escape sequences.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve spec wording

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 364:

> 362:     @Override @DefinedBy(Api.COMPILER_TREE)
> 363:     public Void visitEscape(EscapeTree tree, Void ignore) {
> 364:         hasNonWhitespaceText = true;

What's the significance of setting this flag here? It doesn't seem to be set in `visitEntity`, for example.

Anyway, when I commented L364 out, no tests failed.

-------------

PR: https://git.openjdk.org/jdk/pull/12372


More information about the compiler-dev mailing list