RFR: 7033677: potential cast error in MemberEnter

Jan Lahoda jlahoda at openjdk.org
Thu Feb 16 21:39:06 UTC 2023


On Thu, 16 Feb 2023 19:12:23 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

> In an `import` statement, the thing imported is always a `JCFieldAccess` (it's not legal in Java to import a simple name).
> 
> Therefore the type of `JCFieldAccess.qualid`, which is currently `JCTree`, is unnecessarily wide and can be narrowed to `JCFieldAccess`.

Looks reasonable to me, but please note that `test/langtools/jdk/javadoc/tool/sampleapi/lib/sampleapi/generator/PackageGenerator.java` needs to be fixed as well - on line 280. (Please see the results from GitHub Actions.)

-------------

PR: https://git.openjdk.org/jdk/pull/12606


More information about the compiler-dev mailing list