RFR: 7033677: potential cast error in MemberEnter [v2]

Jan Lahoda jlahoda at openjdk.org
Fri Feb 17 09:23:18 UTC 2023


On Thu, 16 Feb 2023 23:12:08 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

>> In an `import` statement, the thing imported is always a `JCFieldAccess` (it's not legal in Java to import a simple name).
>> 
>> Therefore the type of `JCFieldAccess.qualid`, which is currently `JCTree`, is unnecessarily wide and can be narrowed to `JCFieldAccess`.
>
> Archie L. Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix Javadoc generator build broken by previous commit.

Looks good to me.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12606


More information about the compiler-dev mailing list