RFR: 8302685: Some javac unit tests aren't reliably closing open files

Vicente Romero vromero at openjdk.org
Fri Feb 17 22:45:24 UTC 2023


On Thu, 16 Feb 2023 21:32:44 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

> Some javac unit tests aren't reliably closing open files. Many were written prior to (or without utilizing) try-with-resources.
> 
> Leaving files and other resources open can cause problems during automated builds, etc.
> 
> This patch updates these tests to use try-with-resource.
> 
> Side note: there is at least one unit test that intentionally leaves a file open - `diags/examples/ProcUnclosedTypeFiles/processors/AnnoProc.java`.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12609


More information about the compiler-dev mailing list