RFR: 8014021: TreeMaker.Params behaves inconsistently when the owning method has the same number of parameters as the number of parameter types requested

Archie L. Cobbs duke at openjdk.org
Sat Feb 18 16:39:35 UTC 2023


On Sat, 18 Feb 2023 06:03:18 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> This doesn't seem to address the concern expressed in the JBS issue about it being a weird dual use. It just seems to be a partial cleanup in the same area.

It's no longer a weird dual use - now it's just a dual use :)

Kidding aside, the method is in fact being used with both scenarios. So the other option would be to create two variants of the method for the two scenarios, at the expense of having the caller choose which one. But looking at it now this only needs to happen in one place, so I agree this would be even better - thanks.

Updated in 8a08b1877b0.

-------------

PR: https://git.openjdk.org/jdk/pull/12627


More information about the compiler-dev mailing list