RFR: 8303078: Reduce allocations when pretty printing JCTree during compilation [v2]

Christoph Dreis duke at openjdk.org
Thu Feb 23 07:06:11 UTC 2023


On Wed, 22 Feb 2023 17:55:34 GMT, Christoph Dreis <duke at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/Pretty.java line 1246:
>> 
>>> 1244:             if (tree.paramKind == JCLambda.ParameterKind.EXPLICIT) {
>>> 1245:                 printExprs(tree.params);
>>> 1246:             } else {
>> 
>> nit, just below: `String sep = "";` -> `char sep = '\0';` also `sep = ","` -> `sep = ','`?
>
> Done

This failed the build - I reverted it.

-------------

PR: https://git.openjdk.org/jdk/pull/12667


More information about the compiler-dev mailing list