RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v2]

Fri Feb 24 16:04:38 UTC 2023

On Fri, 24 Feb 2023 11:49:55 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> I think a CSR is needed as we will be generating more warnings and projects compiling with -Werror could see compilation errors

Will do - thanks.

> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java line 280:
> 
>> 278:      * Currently available.
>> 279:      */
>> 280:     public static final long UNUSED_1 = 1L<<48;
> 
> what about just adding the comment saying that this spot is free without declaring an unused flag?

Works for me - as long as it's OK that this will cause the `Flags` enum constant ordinals to renumber after that point.

Fixed in 0131b9b23a2.

-------------

PR: https://git.openjdk.org/jdk/pull/12645