RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v4]

[Archie L. Cobbs]

On Fri, 24 Feb 2023 22:24:10 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie L. Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in one comment and clarify another.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 2730:
> 
>> 2728:             types.membersClosure(site, false).getSymbols(new ClashFilter(site), RECURSIVE).spliterator(), false)
>> 2729:           .map(MethodSymbol.class::cast)
>> 2730:           .filter(m -> m.owner.type.tsym != syms.objectType.tsym)
> 
> nit: this filter could be folded with the one above, `new ClashFilter(site)`

Should be fixed in 7d8a54c6679.

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 2772:
> 
>> 2770:                 java.util.List<MethodSymbol> overriddenMethods = list.stream()
>> 2771:                   .filter(m2 -> m2 != m)
>> 2772:                   .filter(m2 -> overrides.test(m, m2))
> 
> can these two filters be folded?

Should be fixed in 7d8a54c6679.

-------------

PR: https://git.openjdk.org/jdk/pull/12645