RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

Mon Feb 27 11:11:07 UTC 2023

On Sat, 25 Feb 2023 16:03:39 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 2765:
>> 
>>> 2763:      *  any other methods; in this case the class is definitely responsible.
>>> 2764:      */
>>> 2765:     BiPredicate<MethodSymbol, MethodSymbol> buildResponsiblePredicate(Type site,
>> 
>> this method not only builds the predicate as its name indicates, it also removes methods from the `methodGroups`, not saying that we should split this method but I think that this removing activity should be mentioned in the comment above
>
> Oops, my bad - previous refactoring was incomplete.
> 
> Should be fixed in e25ceced163.
> 
> Thanks again for the careful review!

sure, thanks, nice refactoring

-------------

PR: https://git.openjdk.org/jdk/pull/12645