Integrated: 8302685: Some javac unit tests aren't reliably closing open files
Archie L. Cobbs
duke at openjdk.org
Mon Feb 27 16:25:22 UTC 2023
On Thu, 16 Feb 2023 21:32:44 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:
> Some javac unit tests aren't reliably closing open files. Many were written prior to (or without utilizing) try-with-resources.
>
> Leaving files and other resources open can cause problems during automated builds, etc.
>
> This patch updates these tests to use try-with-resource.
>
> Side note: there is at least one unit test that intentionally leaves a file open - `diags/examples/ProcUnclosedTypeFiles/processors/AnnoProc.java`.
This pull request has now been integrated.
Changeset: 55e6bb6b
Author: Archie L. Cobbs <archie.cobbs at gmail.com>
Committer: Vicente Romero <vromero at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/55e6bb6b85828f9a0ac37467ac2d28fd3349c64f
Stats: 445 lines in 58 files changed: 54 ins; 205 del; 186 mod
8302685: Some javac unit tests aren't reliably closing open files
Reviewed-by: darcy, vromero
-------------
PR: https://git.openjdk.org/jdk/pull/12609
More information about the compiler-dev
mailing list