RFR: 8163229: test test/tools/javac/CaptureInSubtype.java has a main method that is never executed Export [v3]

Vicente Romero vromero at openjdk.org
Thu Jan 5 20:05:58 UTC 2023


On Mon, 19 Dec 2022 15:44:08 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

>> This PR deals with some housekeeping relating to compiler unit tests.
>> 
>> JDK-8163229 points out that there are several tests that have a `public static void main(String[])` method, but because the test expects to fail during compilation, the test is never actually run, and so these `main` methods are just clutter that can be removed.
>> 
>> However, there are also some tests where the test is never run, but the `main()` method generates one or more of the expected compilation errors. Obviously we need to keep those, but they don't need to be declared as `public static void main(String[])` which is misleading. So instead we rename these methods to `meth()`, and also we remove the `String[]` parameter when it's not needed by the test.
>
> Archie L. Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge branch 'master' into JDK-8163229
>  - Merge branch 'master' into JDK-8163229
>  - Rename or remove "main()" methods in tests that never actually run.

test/langtools/tools/javac/limits/ArrayDims2.java line 35:

> 33:         [][][][][][][][][][]
> 34:         [][][][][][][][][][]
> 35:         [][][][][][][][][][]

given that you are in the neighborhood :), the main method at: ArrayDims3.java can also be removed. Or can be done in another phase as you please

-------------

PR: https://git.openjdk.org/jdk/pull/10992


More information about the compiler-dev mailing list