RFR: 8043251: Bogus javac error: required: no arguments, found: no arguments [v3]

Archie L. Cobbs duke at openjdk.org
Fri Jan 6 18:00:47 UTC 2023


On Fri, 6 Jan 2023 17:37:12 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie L. Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8043251
>>  - Merge branch 'master' into JDK-8043251
>>  - Fix confusing error message regarding wrong number of type parameters.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java line 4180:
> 
>> 4178:             // so use the error message that omits them to avoid confusion.
>> 4179:             switch (c.snd.getCode()) {
>> 4180:             case "compiler.misc.wrong.number.type.args":
> 
> minor indentation suggestion: I would move the statements inside of the `switch` block to the right

Thanks, it is inconsistent with the style in that file. Fixed in 3f8c9509861.

-------------

PR: https://git.openjdk.org/jdk/pull/10799


More information about the compiler-dev mailing list