Integrated: 8163229: several regression tests have a main method that is never executed

Archie L. Cobbs duke at openjdk.org
Tue Jan 17 04:47:13 UTC 2023


On Fri, 4 Nov 2022 16:30:10 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

> This PR deals with some housekeeping relating to compiler unit tests.
> 
> JDK-8163229 points out that there are several tests that have a `public static void main(String[])` method, but because the test expects to fail during compilation, the test is never actually run, and so these `main` methods are just clutter that can be removed.
> 
> However, there are also some tests where the test is never run, but the `main()` method generates one or more of the expected compilation errors. Obviously we need to keep those, but they don't need to be declared as `public static void main(String[])` which is misleading. So instead we rename these methods to `meth()`, and also we remove the `String[]` parameter when it's not needed by the test.

This pull request has now been integrated.

Changeset: 382fe51b
Author:    Archie L. Cobbs <archie.cobbs at gmail.com>
Committer: Julian Waters <jwaters at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/382fe51b6d7eba7094afa070032bedaa9ffc0633
Stats:     191 lines in 129 files changed: 0 ins; 72 del; 119 mod

8163229: several regression tests have a main method that is never executed

Reviewed-by: vromero

-------------

PR: https://git.openjdk.org/jdk/pull/10992


More information about the compiler-dev mailing list