RFR: JDK-8310550: Adjust references to rt.jar [v5]
David Holmes
dholmes at openjdk.org
Thu Jul 6 07:35:12 UTC 2023
On Thu, 22 Jun 2023 09:23:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> test/langtools/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java line 1:
>>
>>> 1: /*
>>
>> The name of this test includes RTJar. It needs to be changed too I think. Does this test actually still test something?
>
> It seems to start a javap. So I think it tests something, how important this is and what other tests might cover similar stuff, I do not know unfortunately .
This is a trivial test for a trivial issue. javap will be tested much more thoroughly by other tests. I think this test can be deleted without any loss of coverage. Or it can just be left.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1254047816
More information about the compiler-dev
mailing list