RFR: 8194743: Compiler implementation for Statements before super() [v7]
Archie Cobbs
acobbs at openjdk.org
Fri Jul 7 21:21:24 UTC 2023
On Fri, 7 Jul 2023 19:05:29 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into SuperInit
>> - Fix mistake in previous merge commit 80ba6be4.
>> - Merge branch 'master' into SuperInit
>> - Rename unit test to be consistent with other feature exampless.
>> - Update unit test after merged-in commit eaa80ad08.
>> - Add unit tests with local class decl's prior to super().
>> - Merge branch 'master' into SuperInit
>> - Use @enablePreview in tests in preference to explicit command line flags.
>> - Make "statements before super()" support a preview feature.
>>
>> Thanks to Jim Laskey for help with preview logic.
>> - Small refactoring to avoid redundant test.
>> - ... and 15 more: https://git.openjdk.org/jdk/compare/c0aa6bf4...a5f8cc5e
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 4078:
>
>> 4076:
>> 4077: @Override
>> 4078: public void visitClassDef(JCClassDecl tree) {
>
> will you be descending into lambdas with this visitor?
Yes, that's the intent. For good measure, I just added an explicit test to verify that `super()` inside a lambda is not allowed in b0b13b2ad22.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1256489033
More information about the compiler-dev
mailing list