RFR: 8305955: Remove Visual C++ specific workaround in javac [v2]

Joe Darcy darcy at openjdk.org
Tue Jul 11 02:28:22 UTC 2023


On Fri, 23 Jun 2023 02:45:25 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Visual C++ no longer requires the use of the i64 literal syntax and instead recommends the use of LL instead, so we should remove this workaround in the JNIWriter (this also helps when users write Windows JNI code meant to be compiled with alternate compilers other than Visual C++)
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-2
>  - Remove Visual C++ specific workaround in javac

Catching up on reviews...

For the behavioral change being proposed, I think a CSR is deserved (as well as a release note).

I concur with @jonathan-gibbons 's suggestion of providing some kind of configuration knob to get the hold behavior in case is matters in an unanticipated situation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13457#issuecomment-1630004977


More information about the compiler-dev mailing list