RFR: 8311815: Incorrect exhaustivity computation [v2]

Jan Lahoda jlahoda at openjdk.org
Fri Jul 14 19:12:18 UTC 2023


On Fri, 14 Jul 2023 18:49:47 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8311815
>>  - 8311815: Incorrect exhaustivity computation
>>  - 8311038: Incorrect exhaustivity computation
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 3511:
> 
>> 3509:         public RecordPattern(Type recordType, Type[] fullComponentTypes, PatternDescription[] nested) {
>> 3510:             this(recordType, hashCode(-1, recordType, nested), fullComponentTypes, nested);
>> 3511:             if ("test.Test.R(test.Test.C _, test.Test.R(test.Test.C _, test.Test.R(test.Test.C _, test.Test.C _, test.Test.C _), test.Test.I _), test.Test.I _)".equals(toString())) {
> 
> sorry missed this, this seems like testing code that should be removed right?

Oops, sorry, will fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14872#discussion_r1264063915


More information about the compiler-dev mailing list