RFR: JDK-8310835: Address gaps in -Xlint:serial checks [v4]

Raffaello Giulietti rgiulietti at openjdk.org
Tue Jul 18 22:01:45 UTC 2023


On Sat, 15 Jul 2023 02:05:24 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Improve serial lint messages for externalizable records (and potentially other situations).
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactor Externalizable check.

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 5218:

> 5216: 
> 5217:                         if (isExtern && externMethodNames.contains(name)) {
> 5218:                             log.warning(LintCategory.SERIAL,

The check for an enum class seems less specific than for record classes, where not only the name but also the flags, return and parameter types are checked.
But for enum classes this also holds for other methods and fields, so it might be a deliberate choice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14639#discussion_r1267341421


More information about the compiler-dev mailing list