RFR: JDK-8264488: Improve warning for module names ending with digits [v2]

Sebastian Stenzel duke at openjdk.org
Sat Jun 3 05:46:39 UTC 2023


On Wed, 24 May 2023 20:00:15 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Sebastian Stenzel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   applied latest proposal
>>   
>>   result of discussion openjdk/jdk#14099
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties line 1864:
> 
>> 1862: # 0: name
>> 1863: compiler.warn.poor.choice.for.module.name=\
>> 1864:     module name component {0} ends with a digit. Module names should not encode version information in module names
> 
> Duplicate text
> 
> _Module names_. should not ... in _module names_

fixed in eed69a0

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14099#discussion_r1215244676


More information about the compiler-dev mailing list