RFR: JDK-8309568 javac crashes attempting to -Xprint on a class file of an unnamed class
Joe Darcy
darcy at openjdk.org
Tue Jun 6 22:52:56 UTC 2023
On Tue, 6 Jun 2023 22:14:57 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:
> Test development for [JDK-8309503](https://bugs.openjdk.org/browse/JDK-8309503) found that javac crashed attempting to -Xprint on a class file of an unnamed class. The test for ClassReader detecting of unnamed class was forcing completion of the owner class. The new code uses a flags only test.
>
> Related test is with https://bugs.openjdk.org/browse/JDK-8309503 .
Approving in the sense of affirming the related test passes; one or more javac engineers should review the change too.
I confirm that the tests now in https://github.com/openjdk/jdk/pull/14321 pass when run with the changes in this PR.
-------------
Marked as reviewed by darcy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14344#pullrequestreview-1466259160
PR Comment: https://git.openjdk.org/jdk/pull/14344#issuecomment-1579560542
More information about the compiler-dev
mailing list