RFR: JDK-8309503: Improve javax.lang.model tests for JEP 445 [v4]

Joe Darcy darcy at openjdk.org
Wed Jun 7 04:29:55 UTC 2023


On Tue, 6 Jun 2023 22:53:15 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Improve testing methodology for unnamed classes in javax.lang.model, including coverage of binary names.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Update test.
>  - Merge branch 'master' into JDK-8309503
>  - Merge branch 'master' into JDK-8309503
>  - Refine semantics of what is tested.
>  - Merge branch 'master' into JDK-8309503
>  - Improve test to make sure some checking is done.
>  - JDK-8309503: Improve javax.lang.model tests for JEP 445

Note using the enablePreview jtreg in the test rather than the explicit option to the compile commands didn't work; I didn't try to investigate in detail.

Note I'll revert the changes in ClassReader.java before pushing; they were borrowed from https://github.com/openjdk/jdk/pull/14344 to get the test working with a corrected javac.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14321#issuecomment-1579863718


More information about the compiler-dev mailing list