RFR: JDK-8309870: Using -proc:full should be considered requesting explicit annotation processing

[Jonathan Gibbons]

On Mon, 12 Jun 2023 17:28:48 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Address a small omission to the recent addition of "javac -proc:full", regard "-proc:full" as explicitly requesting annotation processing. Also add "-A" to the list of options indicating explicit annotation processing was requested.
> 
> The intention is to backport this bug fix to JDK 21 too.

Approved, with suggestion to relocate comment.

src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java line 96:

> 94:      * options, the list of options regarded as requesting explicit
> 95:      * annotation processing in JavaCompiler should be updated.
> 96:      */

(minor) consider moving this option to before the declaration of `Option` so that it seems less like it applies to the first member.  It could even be an `@implNote` on the enum.

-------------

Marked as reviewed by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14423#pullrequestreview-1475494129
PR Review Comment: https://git.openjdk.org/jdk/pull/14423#discussion_r1227037098