RFR: JDK-8310061: Note if implicit annotation processing is being used [v4]

Jonathan Gibbons jjg at openjdk.org
Wed Jun 28 17:12:58 UTC 2023


On Wed, 21 Jun 2023 23:09:14 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Emit a note warning of the possibility of changing the implicit running of annotation processors in a future release.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Expand cases where an annotation processor path is detected.

src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java line 239:

> 237:     public Log log;
> 238: 
> 239:     /** Whether or not the options lint category was initially disabled

You've copied my pattern of misuse.  "Whether or not" is not recommended use, whether or not you like it.
The consensus is to use just `whether`;  `whether or not` means `regardless`

FWIW, I still like the `whether or not` form!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14499#discussion_r1245528247


More information about the compiler-dev mailing list