RFR: 8303755: Clean up around JavacElements.getAllMembers

[Jonathan Gibbons]

On Tue, 7 Mar 2023 15:20:29 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this cleanup which consists of commentary changes and code simplifications.

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java line 844:

> 842:                     return
> 843:                         thatRank < thisRank ||
> 844:                         thatRank == thisRank &&

(minor).  both before and after, the formulation is confusing and could benefit from parentheses or better indentation

src/jdk.compiler/share/classes/com/sun/tools/javac/util/Iterators.java line 89:

> 87:                 while (input.hasNext()) {
> 88:                     E sym = input.next();
> 89:                     assert sym != null; // otherwise, false positive EOF

javac coding style is to use the `Assert` class, not `assert` statement

-------------

PR: https://git.openjdk.org/jdk/pull/12904