RFR: 8303755: Clean up around JavacElements.getAllMembers [v6]

[Maurizio Cimadamore]

On Wed, 8 Mar 2023 13:08:44 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this cleanup which consists of commentary changes and code simplifications.
>
> Pavel Rappo has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Drop recomputation improvements
>    
>    This reverts e18c0444cbe9f325d7122b97531869d2b8fedc56. Both `rank`
>    and `supertype` are _cached_ anyway, so the performance is not
>    a concern here. As for readability, while it's not really better,
>    it stands out from the rest of the file where everything is
>    recomputed on demand rather than cached and reused.
>    
>    However, this adds clarifying parentheses for `rank` in `precedes`.
>  - Repair botched merge
>    
>    6515bf762a0ffb4a8686e07ae37611507cf2b1be

Generally it looks good, however the PR does two rather different things. One is to fix some typos and minor stylistic issues in the code (e.g. lack of parenthesized expression). The changes on `Iterators` are a bit more delicate as already outlined in the review - and should, in principle be benchmarked before/after to make sure no performance regression is introduced. For these reasons, it would be perhaps cleaner if this PR was split into two parts.

-------------

PR: https://git.openjdk.org/jdk/pull/12904