Integrated: 8303882: Refactor some iterators in jdk.compiler

Pavel Rappo prappo at openjdk.org
Tue Mar 14 18:40:07 UTC 2023


On Thu, 9 Mar 2023 13:14:27 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this refactoring to iterators in jdk.compiler. The refactoring delegates more to collections framework, while retaining the performance characteristics of bespoke iterators. The refactoring also adds inline comments, `@Override` annotations, and fixes some trivial bugs (as can be seen in the added test, which is slightly augmented from that suggested by Jan Lahoda here https://github.com/openjdk/jdk/pull/12904#discussion_r1129777660).
> 
> I'll add a comment here once I have benchmarked the change formally.

This pull request has now been integrated.

Changeset: f81e1def
Author:    Pavel Rappo <prappo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f81e1def8f74e91dcf7fa3bf54531a85956dc5e4
Stats:     269 lines in 3 files changed: 218 ins; 39 del; 12 mod

8303882: Refactor some iterators in jdk.compiler

Co-authored-by: Jan Lahoda <jlahoda at openjdk.org>
Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.org/jdk/pull/12949


More information about the compiler-dev mailing list