RFR: 8303784: no- at Target annotations should be applicable to type parameter declarations [v3]

[Vicente Romero]

On Thu, 23 Mar 2023 04:28:19 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make fix contingent on --release 14
>>   
>>   based on discussion in CSR.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 3515:
> 
>> 3513:         List<Attribute> targets = typeAnnotations.annotationTargets(a.annotationType.type.tsym);
>> 3514:         return (targets == null) ?
>> 3515:                 (source.compareTo(Source.JDK14) >= 0 && isTypeParameter) :
> 
> Usually this kind of test is done using a constant in the Feature enum; I'll let Vicente or other engineer who focuses on javac weigh in on whether or not the direct comparison is acceptable in this case.

right I agree we should add a new member to the Feature enum

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12914#discussion_r1147924651