RFR: 8277501: Revisit PathFileObject.getCharContent and friends [v2]

Archie L. Cobbs duke at openjdk.org
Fri Mar 31 23:00:55 UTC 2023


On Fri, 31 Mar 2023 15:26:18 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie L. Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into JDK-8277501
>>  - Avoid over-reliance on InputStream.available() in BaseFileManager.makeByteBuffer().
>>  - Adjust the semantics of ByteBuffer.appendStream() to not close the stream.
>
> tier1-4 green

Hi @vicente-romero-oracle ,

> would like to close this one, any other comments?

If you're asking me, I think renaming `ByteBuffer` is a reasonable idea but should go into a separate PR (guess I'm trying to avoid mission creep). So I'm ready to wrap this one up but am happy to entertain other opinions.

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12755#issuecomment-1492697935


More information about the compiler-dev mailing list