RFR: 8302344: Compiler Implementation for Unnamed patterns and variables (Preview) [v13]

Fri May 5 09:29:47 UTC 2023

On Fri, 5 May 2023 08:41:08 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java line 88:
>> 
>>> 86:  * or deletion without notice.</b></p>
>>> 87:  */
>>> 88: @SuppressWarnings("preview")
>> 
>> isn't it better to apply the annotation to the method below?
>
> Yeap, this is what I thought at first but I was getting  "warnings found and -Werror specified". So compilation was failing.

IIRC the error is reported on the class level (with position on the class), so suppressing the warning on the method is not sufficient. We might want to review if the warning could have a better position, but we probably should not do it under this patch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13528#discussion_r1185855689