RFR: 8302344: Compiler Implementation for Unnamed patterns and variables (Preview) [v13]

Aggelos Biboudis abimpoudis at openjdk.org
Fri May 5 10:41:24 UTC 2023


On Fri, 5 May 2023 08:06:19 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java line 438:
>> 
>>> 436:     }
>>> 437: 
>>> 438:     public boolean isUnnamed() {
>> 
>> Should this method get the '@Override @DefinedBy(Api.LANGUAGE_MODEL)' markup?
>
> +1 (I am a bit surprised the tests don't complain, that might be something to look at as well)

Note that `Element` does not declare `isUnnamed`.

`isUnnamed` overrides method in `VariableElement` (javax.lang.model.element) via subclass `VarSymbol` in `Symbol`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13528#discussion_r1185944024


More information about the compiler-dev mailing list