RFR: JDK-8307563: make most fields final in `JavacTrees`

[Jonathan Gibbons]

On Fri, 5 May 2023 22:10:19 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Please review a small cleanup fix to address a comment left a long time back.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java line 221:
> 
>> 219:         fileManager = context.get(JavaFileManager.class);
>> 220:         var task = context.get(JavacTask.class);
>> 221:         javacTaskImpl = (task instanceof JavacTaskImpl taskImpl) ? taskImpl : null;
> 
> Suggestion:
> 
>         javacTaskImpl = context.get(JavacTask.class) instanceof JavacTaskImpl taskImpl
>                 ? taskImpl : null;

I don't see that as a significant improvement.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13847#discussion_r1190433247