RFR: 8288619: Unexpected parsing for @see
Jonathan Gibbons
jjg at openjdk.org
Fri May 12 21:35:46 UTC 2023
On Fri, 12 May 2023 21:31:09 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Hi all,
>>
>> When invoking the method `DocCommentParser::quotedString` with field `newline` as `true`
>> and the quoted string has the character `@`, `quotedString` will break the loop and return `null`.
>> This patch changes the field `newline` to `false` at the beginning of the method `quotedString`
>> to solve this issue. And a corresponding test case is added.
>>
>> Thanks for the review.
>>
>> Best Regards,
>> -- Guoxiong
>
> test/langtools/tools/javac/doctree/SeeTest.java line 59:
>
>> 57: * @see "{@code}"
>> 58: */
>> 59: void at_sign_in_quote_string() { }
>
> (minor) add `d` after `quote` in method name
Also, add a test case for this, with a newline after the tag:
/**
* abc.
* @see
* "{@code ...}"
*/
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13888#discussion_r1192811508
More information about the compiler-dev
mailing list