RFR: 8305582: Compiler crash when compiling record patterns with var [v4]

Vicente Romero vromero at openjdk.org
Mon May 22 15:00:51 UTC 2023


On Mon, 22 May 2023 12:45:45 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> While `var` is not allowed in record pattern position the compiler was not checking it. This PR address this issue, by introducing the relevant error symbols and error types.
>> 
>> e.g., `if (o instanceof ColoredPoint(var(var x, var y), var c)) { }`
>
> Aggelos Biboudis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Introduce check in Flow
>  - Merge branch 'master' into fix-#8305582
>  - Update output for DeconstructionpatternsNonVar example
>  - Add more tests
>  - 8305582: Compiler crash when compiling record patterns with var

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13331#pullrequestreview-1436830656


More information about the compiler-dev mailing list