RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

[Jim Laskey]

On Thu, 2 Nov 2023 12:11:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> The spec has been updated to include implicit classes.
>
> Uhmm. In the spec I see implicit classes named here:
> 
> 
>  For reference, the following constructs are declared implicitly in source code, but are not marked as mandated because only formal parameters and modules can be so marked in a class file (JVMS §4.7.24, JVMS §4.7.25):
>  ```
> 
> Note the `but are not marked as mandated`.
> 
> I don't think javac sets the mandated flag for any of these. Note that ACC_MANDATED has the same value as the ACC_MODULE flag, so setting that flag on a class w/o at least filtering out when writing the classfile will be problematic.

Hmmm. I'll check with Gavin, but I thought in discussions Alex said that it should be mandated. At any rate, seems the ACC_MANDATED should be removed for stated reasons.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1380022715