RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v4]

Jim Laskey jlaskey at openjdk.org
Thu Nov 2 14:56:36 UTC 2023

On Thu, 2 Nov 2023 13:53:02 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>>   Remove MANDATED flag from implicit classes
> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 76:
>> 74:         UNNAMED_CLASSES,
>> 75:         @JEP(number=999, title="Implicit Classes and Instance Main Methods")
>> 76:         IMPLICIT_CLASSES,
> I assume you'll change this to 463 before integrating.  Can 445 be removed or is there an issue with the symbol database that means it has to stay for a release?

Missed that. The issue is that Implicit Classes don't have any API and don't show up in the preview page. Fixed.


PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1380274616

More information about the compiler-dev mailing list