RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v8]

Jim Laskey jlaskey at openjdk.org
Thu Nov 2 17:56:13 UTC 2023


On Thu, 2 Nov 2023 17:45:51 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Amazingly enough I seem to have the JNI straight on the first try.
>
>> Amazingly enough I seem to have the JNI straight on the first try.
> 
> Oh, I wasn't expecting that. My comment was suggesting we change LauncherHelper.checkAndLoadMain to set both appClass and mainType after the validate succeeds.

I thought it was a clearer way to get rid of the side effect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1380585433


More information about the compiler-dev mailing list