RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

Jim Laskey jlaskey at openjdk.org
Thu Nov 2 17:59:14 UTC 2023


On Thu, 2 Nov 2023 17:26:19 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revised implicit class test
>
> test/jdk/java/lang/Class/ImplicitClass/TestImplicitClass.java line 25:
> 
>> 23: 
>> 24: /*
>> 25:  * @test
> 
> As a mild preference, I would move this test into the javac/langtools tests. I don't think it tests the reflection anymore, it rather tests that javac desugars the code correctly.

Moving

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1380588699


More information about the compiler-dev mailing list