RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v10]

Jim Laskey jlaskey at openjdk.org
Fri Nov 3 12:08:09 UTC 2023


On Fri, 3 Nov 2023 01:06:56 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnamed classes from examples.not-yet.txt
>
> src/java.base/share/native/libjli/java.c line 539:
> 
>> 537:                                          "validateMainMethod",
>> 538:                                          "(Ljava/lang/Class;)Ljava/lang/reflect/Method;");
>> 539:     CHECK_EXCEPTION_NULL_LEAVE(validateMainMethod);
> 
> The comment in line 498-499 needs update as `LoadMainClass` no longer validates the main method.
> 
>    * Get the application's main class. It also checks if the main
>    * method exists.

Changing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1381578668


More information about the compiler-dev mailing list