RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v10]

[Jim Laskey]

On Fri, 3 Nov 2023 05:01:19 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnamed classes from examples.not-yet.txt
>
> src/java.base/share/native/libjli/java.c line 544:
> 
>> 542: 
>> 543:     /* Build platform specific argument array */
>> 544:     mainArgs = CreateApplicationArgs(env, argv, argc);
> 
> we build the arguments always even if the main we will end up invoking receives no argument and thus these arguments will be discarded. Could it make sense to create the arguments only if they won't be discarded?

Sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1381587622