RFR: JDK-8315457 Implementation of String Templates (Second Preview) [v4]

Alan Bateman alanb at openjdk.org
Sat Nov 4 13:31:11 UTC 2023

On Fri, 3 Nov 2023 15:29:25 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Update String Templates for a second preview. With the addition of
>> - Expression type and throws are determined from the `process` method of the processor type and not the processor type.
>> - Qualified `STR` and `RAW` are treated the same as unqualified `STR` and `RAW` .
>> - Raw (generic) process types are no longer an error.
> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>  - Merge remote-tracking branch 'upstream/master' into 8315457
>  - Cache process method type in JCStringTemplate
>  - Revert source
>  - Revert @since 22
>  - Accept qualified STR and RAW
>  - String Templates (second preview)

Marked as reviewed by alanb (Reviewer).

src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 424:

> 422:     * @since 21
> 423:     */
> 424:    @PreviewFeature(feature=PreviewFeature.Feature.STRING_TEMPLATES)

I think you can drop both `@since` and `@PreviewFeature` from these methods. This in an internal interface, used for shared secrets, there is a lot of churn in JLA in each release.


PR Review: https://git.openjdk.org/jdk/pull/16202#pullrequestreview-1713768565
PR Review Comment: https://git.openjdk.org/jdk/pull/16202#discussion_r1382392709

More information about the compiler-dev mailing list