RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

Jaikiran Pai jpai at openjdk.org
Tue Nov 7 07:52:30 UTC 2023


On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace <duke at openjdk.org> wrote:

> Hi all,
> 
> Please review this fix for jar tool not producing archive if there is a missing file supplied. Fix is to throw an exception and exit processing when a missing file is supplied. Current behaviour will recognise missing file as an error but continue processing and not produce the archive. Updated ClassPath test to verify jar is not created.
> 
> Thanks,
> Ryan.

Hello Ryan, I ran a few experiments and I am unsure if we should be doing this change. Please consider this following scenario, when using the current implementation in mainline:


echo "hello" > hello.txt
jar -cf foo.jar missing.txt missing2.txt hello.txt

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16423#issuecomment-1797979185


More information about the compiler-dev mailing list